sub trim() twice defined in 88_WEBCOUNT.pm:39 and 99_Utils.pm:128

Begonnen von Nestor, 21 Juni 2019, 23:00:05

Vorheriges Thema - Nächstes Thema

Nestor

I got following error in log:
PERL WARNING: Subroutine trim redefined at ./FHEM/88_WEBCOUNT.pm line 41.

Christoph Morrison

Zitat von: Nestor am 21 Juni 2019, 23:00:05
I got following error in log:
PERL WARNING: Subroutine trim redefined at ./FHEM/88_WEBCOUNT.pm line 41.

Hi Nestor,

thank you for your input. But there is no need to be concerned: It's just a warning and they happen any time you reload FHEM.

Please add "[SOLVED]" to the topic for this thread and close it.

Nestor

Why don't you import the function from 99_Utils?
It seems they do exactly the same.

Christoph Morrison

Zitat von: Nestor am 22 Juni 2019, 17:37:15
Why don't you import the function from 99_Utils?
It seems they do exactly the same.

I'm not the maintainer, it's sachag. Feel free to contact him directly

Nestor

The sub trim() in 88_WEBCOUNT.pm can be removed since 99_Utils.pm is auto-loaded via fhem.pl
Patch attached.

Christoph Morrison

I took maintainership from him. Will publish a reworked version soon. Thank you, Nestor.

Nestor

Any update?
This simple cleanup patch seems not be checked in.

Christoph Morrison

Zitat von: Nestor am 29 Juli 2019, 15:54:30
Any update?
This simple cleanup patch seems not be checked in.

Sorry, did the changes but forgot to commit it to the subversion repository. Will be updated tomorrow morning at 08:00.